Skip to content

removing class-properties #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

weaverryan
Copy link
Member

See #11.

tl;dr we do not actually depend on this library, though Stimulus requires it if you're using its normal `targets = syntax. However, how that currently works with Encore is a bit of a mystery.

Still, I do not believe having this as a dependency solves or does anything. And since it's not part of any release yet, let's remove it.

@tgalopin
Copy link
Contributor

Hum, I'm not sure, as it's used in the recipe

@weaverryan
Copy link
Member Author

weaverryan commented Jan 23, 2021

LOL. So THAT is how/why this works out-of-the-box 🤦

Here's what I think we should do:

A) Remove this as a dependency here. It is not really a dependency
B) In Encore, we bump the dependency to require @babel/preset-env at least 7.10

... and that's all. The plugin would still be added directly in the user's project in webpack.config.js and it would be present thanks to preset-env.

@weaverryan
Copy link
Member Author

This was closed unintentionally - my bad!

@tgalopin
Copy link
Contributor

Should we update the recipe before doing that?

@weaverryan
Copy link
Member Author

@tgalopin I decided not to put the package into the recipe, but just to make sure that it's available indirectly via Encore - in symfony/webpack-encore#889

The tl;dr is this:

A) If you're using Encore today, you probably already have this package. You only don't if you have a bit of an older version of @babel/preset-env
B) If you're using Encore 1.0, then you will DEFINITELY have it because of symfony/webpack-encore#889

We don't have a release of stimulus-bridge yet that includes the @babel/plugin-proposal-class-properties. My vote is to remove it before we ever have a release. And if people get an error that the package is missing (because they are in the edge-case situation), then the fix is for them to install the package or upgrade @babel/preset-env. Either way, the dependency should not be here.

Thanks!

@tgalopin
Copy link
Contributor

Thanks Ryan.

@tgalopin tgalopin merged commit e112b75 into symfony:main Jan 31, 2021
@weaverryan weaverryan deleted the remove-class-properties branch February 1, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants